Minor update to the log functions API #23637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23637-de27e80 | |
| Version | 25.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | de27e80 | |
| App Center Build | WPiOS - One-Offs #10770 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23637-de27e80 | |
| Version | 25.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | de27e80 | |
| App Center Build | jetpack-installable-builds #9812 |
kean
reviewed
Sep 30, 2024
| @@ -2,26 +2,26 @@ import Foundation | |||
| import CocoaLumberjackSwift | |||
|
|
|||
| @inlinable | |||
| public func DDLogVerbose(_ message: @autoclosure () -> Any, file: StaticString = #file, function: StaticString = #function, line: UInt = #line) { | |||
| CocoaLumberjackSwift.DDLogVerbose("\(message())", file: file, function: function, line: line) | |||
| public func DDLogVerbose(_ message: @autoclosure () -> DDLogMessageFormat, file: StaticString = #file, function: StaticString = #function, line: UInt = #line) { | |||
There was a problem hiding this comment.
Is there a reason we are redefining these?
There was a problem hiding this comment.
I think the purpose is making the logging functions available to all files in the project. Otherwise, we'll need to add import CocoaLumberjackSwift in every file that logs thing.
kean
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple and boring changes to make the DDLogXxx functions in the app target match the ones in CocoaLumberjack.
The first comment is the main changes. The second commit is just changing
DDLog(aString)toDDLog("\(aString)")to make compiler happy.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: